From 62254456f7a4b2401e15c5383e0a06cacec2e069 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Mon, 17 Feb 2014 23:09:44 -0500 Subject: [PATCH] GtkLabel: don't eat too many button release events We should only eat button release events when the label is actually selectable, since the comment indicates that we want to eat the release events belonging to press events that triggered a selection. This fixes problems with actions on parent widgets that are triggered by button release, as seen in this bug: https://bugzilla.gnome.org/show_bug.cgi?id=724541 --- gtk/gtklabel.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c index 27e202ebf9..fbb0d87b5d 100644 --- a/gtk/gtklabel.c +++ b/gtk/gtklabel.c @@ -4801,7 +4801,10 @@ gtk_label_button_release (GtkWidget *widget, /* The goal here is to return TRUE iff we ate the * button press to start selecting. */ - return TRUE; + if (info->selectable) + return TRUE; + + return FALSE; } static void -- 2.30.2